-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: isolate binding EventEmitter #1937
Merged
Flarna
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:async-hooks-no-leak
Feb 22, 2021
Merged
fix: isolate binding EventEmitter #1937
Flarna
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:async-hooks-no-leak
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding an EventEmitter a second time via another instances of ContextManager shouldn't have side effects to the first ContextManager. Use an unique symbol per ContextManager instance to isolate them.
Flarna
requested review from
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
February 16, 2021 19:02
dyladan
approved these changes
Feb 17, 2021
vmarchaud
approved these changes
Feb 17, 2021
This comment has been minimized.
This comment has been minimized.
dyladan
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Feb 17, 2021
obecny
reviewed
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor things
packages/opentelemetry-context-async-hooks/src/AbstractAsyncHooksContextManager.ts
Show resolved
Hide resolved
packages/opentelemetry-context-async-hooks/test/AsyncHooksContextManager.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-context-async-hooks/src/AbstractAsyncHooksContextManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-context-async-hooks/src/AbstractAsyncHooksContextManager.ts
Outdated
Show resolved
Hide resolved
MSNev
approved these changes
Feb 17, 2021
obecny
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, the last thing is minor anyway leaving this up to you
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Binding an
EventEmitter
a second time via another instances ofContextManager
shouldn't have side effects to the firstContextManager
.Short description of the changes
Use an unique symbol per
ContextManager
instance to isolate them.